search

wix-incubator / mjml-react

React component library to generate the HTML emails on the fly
MIT License
993 stars 50 forks source link

fix(mjml-social): handle new properties #23

Closed nolanrigo closed 5 years ago

nolanrigo commented 5 years ago

Hello,

Since mjml@4.21 we can use text-padding & icon-padding on both mjml-social & mjml-social-element. We can already use them but I think it should be useful to add numberToPx handler to these properties.

I will try to add them to typescript def.

I'm not really used to contribute to open project, let me know if I made mistakes

mastertheblaster commented 5 years ago

Great job!

mastertheblaster commented 5 years ago

@nolanrigo thanks for the PR. It's merged and new version is already available 1.0.52. Good luck!