Loosen react & react-dom peer deps to 17.x

wix-incubator / mjml-react

React component library to generate the HTML emails on the fly

MIT License

989 stars 50 forks source link

Loosen react & react-dom peer deps to 17.x #56

Closed mdarens closed 3 years ago

mdarens commented 3 years ago

Per the announcement post, React v17 doesn't remove any methods deprecated in previous versions. After cloning the mjml-react repo & setting the peer deps for react & react-dom to 17.x, I was able to get the e2e tests to pass, despite warnings about the yoshi tool (I had to downgrade it to the latest version available on the public npm feed). Could this change be made upstream?

Thanks for your time!

mdarens commented 3 years ago

whoops, looks like this is a duplicate of #49.