search

wix-incubator / mjml-react

React component library to generate the HTML emails on the fly
MIT License
989 stars 50 forks source link

Support for mj-html-attributes, mj-selector, mj-html-attribute? #71

Closed philipwindeyer closed 2 years ago

philipwindeyer commented 2 years ago

Hello, is there a timeline on adding support for the newer mj-html-attributes, mj-selector, and mj-html-attribute head components?

I.e. https://documentation.mjml.io/#mj-html-attributes

Thanks in advance

daliusd commented 2 years ago

There is pull request https://github.com/wix-incubator/mjml-react/pull/54 but it is conflicting with master. Wanna fix it?

philipwindeyer commented 2 years ago

Saw that; although it's a year old and it's attempting to redefine MjmlAttributes as MjmlHtmlAttribute 😕.

I can dedicate time to this on Monday. Will open a new PR then if that works for you? @daliusd

daliusd commented 2 years ago

Yes, it works for me.

philipwindeyer commented 2 years ago

Hey @daliusd, just opened https://github.com/wix-incubator/mjml-react/pull/72 . Will update types in DefinitelyTyped shortly

daliusd commented 2 years ago

Hi @philipwindeyer we will review it.

philipwindeyer commented 2 years ago

FYI: PR for accompanying typedefs, for the TypeScripters https://github.com/DefinitelyTyped/DefinitelyTyped/pull/59026