wix-incubator / mjml-react

React component library to generate the HTML emails on the fly
MIT License
993 stars 50 forks source link

Package dependencies with mjml-react #78

Closed psugihara closed 2 years ago

psugihara commented 2 years ago

Quick question I hope. What's the reason that mjml-react requires you to install extra dependencies with it? Can they be included in mjml-react?

It would be simpler for users to npm install mjml-react rather than npm install react react-dom mjml mjml-react. I know it's tripped up a few people (#69 👋).

I'm sure this has been considered, so I wanted to understand the reasoning/limitation.

Thanks, this is a great lib!

daliusd commented 2 years ago

We can't bind to specific version as user might be forced to use specific version in their situation.

psugihara commented 2 years ago

Got it, thanks!