search

wix-incubator / mjml-react

React component library to generate the HTML emails on the fly
MIT License
992 stars 50 forks source link

A dependency `"react-reconciler": "^0.26.1"` is blocking to use `react>=18` #87

Closed tkamenoko closed 2 years ago

tkamenoko commented 2 years ago

mjml-react depends on "react-reconciler": "^0.26.1" that uses "react": "^17.0.2". It blocks to use react>=18 .

This is npm dedupe output of my private project.

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-reconciler@0.26.2
npm WARN Found: react@18.1.0
npm WARN node_modules/react
npm WARN   peer react@"^17.0.2 || ^18.0.0" from @astrojs/react@0.4.2
npm WARN   node_modules/@astrojs/react
npm WARN     dev @astrojs/react@"0.4.x" from @my-project/webapp@0.0.1
npm WARN     packages/webapp
npm WARN   11 more (@linaria/react, @testing-library/react, jotai, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@"^17.0.2" from react-reconciler@0.26.2
npm WARN node_modules/mjml-react/node_modules/react-reconciler
npm WARN   react-reconciler@"^0.26.1" from mjml-react@2.0.8
npm WARN   node_modules/mjml-react
npm WARN
npm WARN Conflicting peer dependency: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^17.0.2" from react-reconciler@0.26.2
npm WARN   node_modules/mjml-react/node_modules/react-reconciler
npm WARN     react-reconciler@"^0.26.1" from mjml-react@2.0.8
npm WARN     node_modules/mjml-react
jonthor-tempo commented 2 years ago

https://github.com/wix-incubator/mjml-react/pull/76 seems to be merged already, just missing a release for it

CloutProject commented 2 years ago

@mastertheblaster Out of curiosity, is a release planned to include the above (allow react v18 as peer dependency) ?

daliusd commented 2 years ago

Hey, sorry to say that but this project is not maintained anymore. That means there will be no more releases as well. Feel free to fork this project if you need anything.