search

wix-incubator / mocha-env-reporter

10 stars 1 forks source link

dynamic deps break shrinkwrap #15

Open viliusl opened 7 years ago

viliusl commented 7 years ago

when you try to do npm shrinkwrap it of course fails, because mocha-env-reporter package.json does not contain teamcity-env-reporter and dep tree is invalid.

Regardless of what we think of npm or shrinkwrap imho it's uncool to break it. Maybe we can keep your introduced behavior and add optionalDependencies to keep npm calm?

viliusl commented 7 years ago

@amir-arad - rollback or try with optionalDependencies ?

paulmelnikow commented 5 years ago

Wouldn't adding the teamcity-env-reporter dependency you need to your package.json along with mocha-env-reporter solve this problem? It seems that would just sidestep this library's dynamic auto-installation behavior.