The current playground is not enough to contribute into playable

wix-incubator / playable

No hassle, no fuss, just nice and easy video player

https://wix-incubator.github.io/playable/

MIT License

97 stars 10 forks source link

The current playground is not enough to contribute into playable #131

Open rudnitskih opened 5 years ago

rudnitskih commented 5 years ago

During working on RTL feature we found only one way how to test playble in different configurations is change something in develop.ts file. This approach is annouying because is diffuclt to understand all possible configurations for library and make some changes.

I propose to describe all options in playground page.

rudnitskih commented 5 years ago

PR - https://github.com/wix/playable/pull/134

rudnitskih commented 5 years ago

TODOs:

[ ] Better integration with oki-doc (make storybook as subpage of docs site, not external links)
[ ] Think about which knobs should be in the playground
[ ] Better code architecture for Story

rudnitskih commented 5 years ago

Quick intro to storybook: https://storybook.js.org/docs/guides/guide-react/ knobs doc: https://www.npmjs.com/package/@storybook/addon-knobs

rudnitskih commented 5 years ago

Unfortunately, after the following npm i some issue with webpack which I don't know how to fix quickly:

Will try to take a look on next week.

rudnitskih commented 5 years ago

@Dariia Did you have any progress with this on Friday?

mykolavlasov commented 4 years ago

BrooklynKing commented 4 years ago

I fixed this problem with new API for css-loader.