search

wix-incubator / react-module-container

Small library for building micro apps in React and Angular
MIT License
69 stars 18 forks source link

Update react-loadable-component.js #84

Closed kobiburnley closed 3 years ago

kobiburnley commented 3 years ago

Fixes https://github.com/wix/react-module-container/issues/83

kobiburnley commented 3 years ago

I wonder if now because this bug is fixed, when an error occurs in resolve, users will keep seeing the spinner, instead of the "Something went wrong" placeholder (BM flow bubbles up the error, I refer to non BM flow projects)

ronenst commented 3 years ago

@kobiburnley I think that is correct, perhaps it's better to do this with an option