wix-incubator / react-native-controllers

Native IOS Navigation for React Native (navbar, tabs, drawer)
MIT License
611 stars 82 forks source link

When changing the root controller, the previous root is leaking until the next setRootController #25

Closed artald closed 8 years ago

artald commented 8 years ago

When setting a new root using the setRootController action, the previously presented root is not dealloced until another root is set.

Example scenario: - the app starts with root A. - the app sets a new root B. A is still not dealloced at this point. - the app sets a new root C. A is now dealloced (but B isn't yet).

siwymilek commented 8 years ago

Probably you mean this issue

artald commented 8 years ago

@siwymilek thanks. the leak is indeed mentioned there but this is a separate issue that needs to be taken care of.

artald commented 8 years ago

Fixed with e02d1d5 and available in release 1.3.3