search

wix-incubator / react-native-interactable

Experimental implementation of high performance interactable views in React Native
MIT License
5.18k stars 516 forks source link

Maintenance #199

Open rotemmiz opened 6 years ago

rotemmiz commented 6 years ago

After merging #198, let's continue with maintenance:

  1. remove postinstall script (we don't need it anymore) and bump minor version, this solves #144, #140, #129, #194, #172.
  2. Add CI with Travis, build project on both platforms and run sanity with Detox on release builds. It will be perfect if we can run iOS on macOS and Android on Linux, but Travis does not support x86 emulators, so we can at least compile the Android version without running it :( (boo to you TravisCI)
  3. Add badges to README.md
mkuczera commented 6 years ago

Hi @rotemmiz , just a ping. Current status:

  1. PR based on #198 can be already made after merge: https://github.com/mkuczera/react-native-interactable/tree/remove-postinstall
  2. Currently setting up the travis checks. Tryout branch with the postInstall change already successfully builded. Also implement basic test for the travis build based on the #196 problem.
mkuczera commented 6 years ago

Hey @rotemmiz , what´s the current status? Without any right, i can´t cleanup the issues and the different tasks and need to ping you :(

Greetings Michael

rotemmiz commented 6 years ago

Hey @mkuczera,

Sorry for not being responsive enough. We really appreciate all that maintenance work and I believe we will be able to soon find a solution as to how we streamline things in this repo, including adding rights to external contributors like yourself. In the meantime, I'll keep watching PRs alongside @Buttershub. I'll review those PRs you mentioned above.

mkuczera commented 6 years ago

Hey @rotemmiz, Hey @ButtersHub , i wanted to ask if there is any update? The issues are stacking up and would be easy to fix, but due to the process i have to wait right now. I know that you guys are busy, but i would appreciate any update to the current status.

Greetings Michael

rotemmiz commented 6 years ago

Hey @mkuczera, the ball is in your hands. We're ready when you are

EricPKerr commented 6 years ago

@rotemmiz @ButtersHub possible to move this to react-community or react-native-community? AirBNB moved their react-native-maps repo to the former a few months ago after they decided to change their approach with RN resources.

st-sloth commented 6 years ago

The postinstall issue is fixed in #211. Would be nice to get it merged and stop this torrent of installing problems.

mnlbox commented 6 years ago

Guys please merge #211 as soon as possible. Ican't build my app because of this issue: https://github.com/wix/react-native-ui-lib/issues/223