search

wix-incubator / react-native-keyboard-input

Use your own custom input component instead of the system keyboard
MIT License
819 stars 150 forks source link

Fix RN 0.48+ warning about requiresMainQueueSetup #50

Open H-H1RO opened 6 years ago

radex commented 6 years ago

@artald Can we merge this? The fix looks correct, and as of RN 0.56 the warning pops up in the yellow box instead of just being hidden in the console

artald commented 6 years ago

@radex Even though returning YES for requiresMainQueueSetup is effectively leaving things as they are right now, it’s not really required and we can probably return NO. I don’t want to break things, but still want to look into it. I’ll check it this week.

radex commented 6 years ago

Ah! Understood — thank you :)

radex commented 6 years ago

@artald Hey! Did you get a chance to look into this? RN 0.56 is shipped and the warnings from this library pop up at every launch