Fix issue while scrolling in Android

wix-incubator / react-native-zss-rich-text-editor

React Native rich text editor based on ZSSRichTextEditor

Other

841 stars 311 forks source link

Fix issue while scrolling in Android #148

Closed diegocouto closed 4 years ago

diegocouto commented 5 years ago

Currently, it isn't possible to scroll in Android devices, once the editor automatically scrolls back to the cursor position.

It seems that the event selectionchange is being triggered during a scroll in Android, what ends up in a call to the function calculateEditorHeightWithCaretPosition.

Versions

Android - 7.0
React Native - 0.57.4

sergiulucaci commented 5 years ago

~Just tried your changes but seems the scroll issue persists.~

My bad, on Android you have to make sure a new version of editor.html is generated into android/app/src/main/assets.

diegocouto commented 5 years ago

You're right @sergiulucaci, a new version of editor.html must be generated after any package update. Was this issue fixed for you once everything was up to date?