Open ColdStar007 opened 5 years ago
same issue
Same here !
@ColdStar007 @minhphung210 @antony-meunier There is an infinite loop running in the android version, it has been resolved in a few different forks but there is little to no activity in this repo unfortunately.
You can depend on the tag 1.1.1 in my fork of this repo which has a fix.
https://github.com/arneson/react-native-zss-rich-text-editor.git#1.1.1
@arneson arn your solution not work for me :( thank for reply
That's unfortunate. Have you made sure to do a clean native build before testing? As the problem is in the editor.html file in the library which is only copied over on build, not reload.
@arneson keen to make a hard fork? I'm having issues. lets collaborate I have a fork too: https://github.com/export-mike/react-native-zss-rich-text-editor
I'm keen to change this to use the recommended react-native-web-view which is faster for ios and also has window.postMessage working without hacks.
@arneson where is the change to remove the infinite loop? https://github.com/arneson/react-native-zss-rich-text-editor/commits/master/src/editor.html
@export-mike
Yeah, I'd love to get this library working properly again. Would love to collaborate.
It's the commit with message fix getCaretPosition.
Worth noting is that I did not write that commit but pulled it from charpeni 's fork.
ok cool sounds great.
basically the fork of the editor I'm using has the ability to render custom buttons. I need to change it to use the react-native-web-view
I can pull in this infinite loop fix manually. what other changes have you introduced?
what functionality are you working to support/fix?
Working on supporting the toolbar which behaves like a fucking tool in the current version.
But totally agree we need a new hard fork. I can create a fork and add you as a collab, that sound good?
14 dec. 2018 kl. 16:59 skrev Mike James notifications@github.com:
ok cool sounds great.
basically the fork of the editor I'm using has the ability to render custom buttons. I need to change it to use the react-native-web-view
I can pull in this infinite loop fix manually. what other changes have you introduced?
what functionality are you working to support/fix?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Yeah great. basically the work I have done so far allows custom components to be rendered.
Bottom 2 points need to be completed.
@export-mike Don't think I've seen the last one. Could you send over a screen shot?
Saw that link way too late. It’s dead now :) @export-mike
@arneson Thanks your fork worked for me!
@arneson your version supports hashtag and mentions?
@ashokkumar88 I have not added that functionality, so if it exists in original package then yes, otherwise no.
looks like UIWebView has been deprecated. I'll be updating https://github.com/export-mike/react-native-zss-rich-text-editor to use WKWebView.
It works fine on iOS, but it runs very slowly on Android.