wix-incubator / react-templates

Light weight templates for react
https://wix.github.io/react-templates
MIT License
2.82k stars 207 forks source link

native option in CLI does not work as expected #167

Closed PierBover closed 8 years ago

PierBover commented 8 years ago

When using react-templates with react-native the docs say:

In native mode the default modules option is set to commonjs and the default react-import-path is set to react-native.

But when using --native with the CLI the modules are not set to commonjs, nor the import path is set to react-native.

Here is the proof.

tr template.rt --native returns:

var templateRT = function () {
    return React.createElement(React.View, {}, React.createElement(React.Text, {}, 'Hola'));
};

tr template.rt --native --modules commonjs returns:

'use strict';
var React = require('react/addons');
var _ = require('lodash');
module.exports = function () {
    return React.createElement(React.View, {}, React.createElement(React.Text, {}, 'Hola'));
};

And finally rt template.rt --modules commonjs --native --react-import-path react-native returns:

'use strict';
var React = require('react-native');
var _ = require('lodash');
module.exports = function () {
    return React.createElement(React.View, {}, React.createElement(React.Text, {}, 'Hola'));
};