no-implicit-dependencies

AviVahl commented 7 years ago

tslint 5.8.0 now has no-implicit-dependencies turned on by default. The rule verifies import statements only refer to packages that are listed as "dependencies" in package.json.

Meaning, if I:

import {Component} from 'react';

It throws an error if react isn't listed as a dependency.

Although it sounds great at first glance, it does have issues:

Ignores peerDeps, which really sucks for our libraries, as we don't want them to force a specific react/stylable version.
Cannot work in our current tests setup, as we use "devDependencies" packages in our tests (chai, sinon, etc.)

I vote to turn it off in our preset for now.

Thoughts?

tyv commented 7 years ago

I agree

tyv commented 7 years ago

I think you may proceed

AviVahl commented 7 years ago

@tyv could you release a new version with this rule included?

npm version patch
npm publish
git push
git push --tags

tyv commented 7 years ago

@AviVahl we don't release patches. https://github.com/wix/tslint-wix-react/blob/master/.github/CONTRIBUTING.md

I will do, thanks!

tyv commented 7 years ago

@AviVahl published as 5.0.0

wix-incubator / tslint-wix-react

no-implicit-dependencies #9