enterValue - don't enter value when input is readOnly

wix-incubator / unidriver

UniDriver - Universal Component Drivers 🚀

MIT License

53 stars 15 forks source link

enterValue - don't enter value when input is readOnly #136

Closed bamai closed 3 years ago

bamai commented 3 years ago

Following this thread: https://wix.slack.com/archives/CM7M5R10W/p1617785086003100

sivanharel commented 3 years ago

@GabiGrin - Thanks for the quick response! If I am not wrong we might need to change it from 'readOnly' to 'readonly' since the HTML attribute that is added is with 'o' and not 'O'. https://www.w3schools.com/tags/att_input_readonly.asp

I could open a new pr with this fix, so maybe we could wait with the release?

GabiGrin commented 3 years ago

@sivanharel sure

GabiGrin commented 3 years ago

It's ok, we double checked and it's the way it should be. element.readOnly is the right API