search

wix-incubator / unidriver

UniDriver - Universal Component Drivers 🚀
MIT License
53 stars 15 forks source link

Add mouse.leave function #165

Closed EgoziE closed 2 years ago

GabiGrin commented 2 years ago

LGTM Bummer that the mouse simulation in pptr / playwright is done using dom events injecting and not via a "true" mouse simulation (as in Page.mouse.move()) but I see previous events were implemented like that so guess it's ok

GabiGrin commented 2 years ago

@Dor256 any ideas why the PW fails

GabiGrin commented 2 years ago

@EgoziE just saw the failing test :sigh: pinging @Dor256 who wrote the adapter - any pointers for @EgoziE to save us some time?

Dor256 commented 2 years ago

@EgoziE just saw the failing test :sigh: pinging @Dor256 who wrote the adapter - any pointers for @EgoziE to save us some time?

Hmm not sure actually... I see that in the puppeteer driver you used a mouseout event while in playwright you used a mouseleave event. Could this be affecting this?

EgoziE commented 2 years ago

Unfortunately, for puppeteer only mouseout actually triggered the mouseleave event. mouseleave by itself didn't trigger anything... :/ I found it by accident

EgoziE commented 2 years ago

@Dor256 What are you suggesting? (and how can I run playwright tests locally? I didn't succeed)

Dor256 commented 2 years ago

@Dor256 What are you suggesting? (and how can I run playwright tests locally? I didn't succeed)

Did you try usingmouseout on playwright as well? Regarding running it locally, npm test should work unless something changed...