wix-incubator / unidriver

UniDriver - Universal Component Drivers 🚀
MIT License
53 stars 15 forks source link

[puppeteer adapter] Move @types/puppeter to devDependencies #186

Open mykas opened 2 years ago

mykas commented 2 years ago

After some of the Wix infrastructure moved to puppeteer major version 14 - consumers started to get the type build failures on types mismatches. This adapter is cross major version compatible and should work fine with puppeteer 14 as there are no actual breaking changes for api that this adapter is using.

The short term solution is to move @types/puppeteer-core to devDeps and unblock users from getting red builds.

The long term solution will be to upgrade this adapter to latest puppeteer and support backwards compatible api as long as possible.

amitdahan commented 2 years ago

@mykas 👋

yakirza17 commented 2 years ago

any update?