search

wix-incubator / vscode-glean

The extension provides refactoring tools for your React codebase
MIT License
1.46k stars 56 forks source link

Lightbulb menu doesn't show conversion actions #113

Closed enstulen closed 4 years ago

enstulen commented 4 years ago

I want to convert a class component to a functional component, but the option doesn't show up in the lightbulb menu.

I downloaded a fresh copy of VsCode so it wouldn't interfere with other extensions, and same thing happens.

ezgif com-video-to-gif

borislit commented 4 years ago

@Hey @enstulen ! Thanks for the issue! I think this has to do with the fact that u are selecting the whole file content. Try selecting JUST the component (without the import and export).

enstulen commented 4 years ago

Thanks for the comment! In the GIF, you see that I first select JUST the component, then I try selected everything else too.

borislit commented 4 years ago

Gocha! I'll have a look at it asap!

borislit commented 4 years ago

Hi @enstulen so I found the issue. Will release the fix tomorrow

borislit commented 4 years ago

:tada: This issue has been resolved in version 5.0.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

borislit commented 4 years ago

Hey @enstulen ! Check out the new version with the fix

enstulen commented 4 years ago

Awesome, thanks!