Suggestion: rename "stateful" and "stateless" to class and function respectively

wix-incubator / vscode-glean

The extension provides refactoring tools for your React codebase

MIT License

1.46k stars 56 forks source link

Suggestion: rename "stateful" and "stateless" to class and function respectively #33

Open OliverJAsh opened 6 years ago

OliverJAsh commented 6 years ago

Thanks for this amazing project!

Quick suggestion: could we rename "stateful" and "stateless" to class and function respectively? Rationale:

There are function and class components. Both can be stateful or stateless but that’s an implementation detail.

As per https://mobile.twitter.com/dan_abramov/status/1057625147216220162

borislit commented 6 years ago

Hey @OliverJAsh ! I've also noticed that tweet, and I agree completely. Always hated those terms, but they were better known within the community and they also fit the terms used in Typescript types definition for React.

Care for a PR? I'd love to assist/split the work. Basically, the change involves

Changing the labels
Renaming variables and functions within the codebase
Changing filenames
Updating the docs

itzsaga commented 5 years ago

I noticed this as well. Just set a reminder for myself on Jan 2nd after the holidays to see if this is still open. If so, I'll try and find some time to submit the PR. 😃

borislit commented 5 years ago

@itzsaga awesome! I'd love to assisst and point you in the right direction!

itzsaga commented 5 years ago

@borislit, back! Ready to be pointed in the right direction 😃 outside of just a project search for the two strings.

borislit commented 5 years ago

@itzsaga hey! Thanks for the initiative :) Ill create a list for ya later tonight :)

borislit commented 5 years ago

Hey @itzsaga ! Sorry for not getting back to You! I was busy working on the Hooks support. Now that its here, This change makes ALOT of sense. Later tonight ill point out the places We'll need to change