wix-incubator / vscode-glean

The extension provides refactoring tools for your React codebase
MIT License
1.46k stars 56 forks source link

Extract to component is broken #37

Open acostaf opened 5 years ago

acostaf commented 5 years ago

Hi Team

Extracting a piece of jsx takes forever to ask for the path then some more secs to ask for the file name and does it, does not do anything else, does not create the file

borislit commented 5 years ago

Hey @acostaf. What's your OS? How big is your repository? Can you post the origin file and the snippet you are trying to extract?

acostaf commented 5 years ago

@borislit

Forgot about it, I am running Windows 7, vscode 1.28.2 node: 8.9.3.

Project is around 40 to 50 files, the file is a js file and I am trying to extract the inner div

      <div className="row">
        <div className="col">
          {chat && chat.messages && (
            <ul className="list-unstyled text-black-50 small">
              {chat.messages.map((item ) => (
                <li key={item.when.toString()}>{`${getChatTime(item.when)} ${item.userId}:${item.text}`} </li>
              ))}
            </ul>
          )}
        </div>
borislit commented 5 years ago

@acostaf can you please post the whole file? Is the repo public?

wunnle commented 5 years ago

Hey @borislit, interestingly Extract Component never worked for me either (installed glean a last week). I just created a new react app to test, but its still broken.

Basically it creates and empty file but never moves the code. I'm using Win 10, vscode 1.28.2

--

Edit: Just played with it a bit more. Looks like its -mostly- not working when it needs to create a new file, but works all the time when I create the file for Glean.

borislit commented 5 years ago

@wunnle are u selected the absolute path or the relative? there is a known issue when you select an absolute path. Can you describe steps to reproduce the issue, the origin code and the snippet you are trying to extract?