search

wix-incubator / vscode-glean

The extension provides refactoring tools for your React codebase
MIT License
1.46k stars 56 forks source link

Auto imports #47

Closed williamluke4 closed 5 years ago

williamluke4 commented 5 years ago

@borislit This requires quite a bit of work but let me know your thoughts

borislit commented 5 years ago

@williamluke4 can you describe overall solution? I think that the version version should be minimal and just handle the React import. Then, once that works, lets expand it to other imports. The more I think of it, the more I understand importing React has plenty of complexity in an of it self

williamluke4 commented 5 years ago

@borislit Might be best to explain a bit more over a call.

borislit commented 5 years ago

@williamluke4 I agree. We can schedule a call on weekend/next week. Meanwhile, WDYT about narrowing the scope for now?

borislit commented 5 years ago

@williamluke4 hey! whats up? You've been missed. Any plans to keep working on this? I've added a basic React import here: https://github.com/wix/vscode-glean/blob/useState-support/src/modules/jsx.ts#L46 WDYT? Also, i'd LOVE a separate PR for the bugfix we discussed. I can create one with ur code if you'd like