wix-incubator / vscode-glean

The extension provides refactoring tools for your React codebase
MIT License
1.46k stars 56 forks source link

Extract to component bug in generated code #62

Closed KatSick closed 5 years ago

KatSick commented 5 years ago

Given input

    <FlatList
        data={collapsedData}
        keyExtractor={item => `${item._eprId}_${item._eprValue}`}
        renderItem={this.makeRenderItem(data)}
        ListHeaderComponent={this.renderHeader}
        ListEmptyComponent={this.renderEmpty}
        onRefresh={this.props.onRefresh}
        refreshing={this.props.refreshing}
      />

Extracted generated (Table named) component

export function Table({
  collapsedData,
  item,
  data,
  _eprId,
  _eprValue,
  makeRenderItem,
  renderHeader,
  renderEmpty,
  onRefresh,
  refreshing
}) {
  return (
    <FlatList
      data={collapsedData}
      keyExtractor={item => `${_eprId}_${_eprValue}`}
      renderItem={makeRenderItem(data)}
      ListHeaderComponent={renderHeader}
      ListEmptyComponent={renderEmpty}
      onRefresh={onRefresh}
      refreshing={refreshing}
    />
  );
}

As you can see keyExtractor is generated incorrectly

borislit commented 5 years ago

@KatSick Thanks for your reporting! ill try getting to this in the coming few days, although PRs are super welcome. Id love to point You in the right direction

KatSick commented 5 years ago

@borislit sounds interesting todo...

borislit commented 5 years ago

@KatSick I found the problem. I hope to have the fix out in coming day or two

borislit commented 5 years ago

:tada: This issue has been resolved in version 4.10.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: