wix-playground / stylable-components

Fully-tested & strictly-typed component library based on React, using optional Wix styling.
MIT License
35 stars 3 forks source link

Update documentation with things related to Theme #538

Closed LeonidLevi closed 6 years ago

LeonidLevi commented 6 years ago

You can see the current status of the documentation here: https://docs.google.com/spreadsheets/d/1y5h43xNKcMnNbn_GTV-4XSBRDbNmHj8YRYjel26uGto/edit#gid=2047332282

Docs for some components weren't updated because the components are unfinished, in the process of changing, have open pull requests, or their final implementation is blocked by something.

(Notably Portal incompatibility with Theming, and the bug with not being able to expose elements stored in variables or functions as subselectors)

arnonkehat commented 6 years ago

I think you can merge.

On Oct 26, 2017 10:32 AM, "Leonid Levi" notifications@github.com wrote:

@LeonidLevi commented on this pull request.

In docs/checkbox/readme.md https://github.com/wix/stylable-components/pull/538#discussion_r147063735 :

@@ -58,15 +58,26 @@ export class BasicDemo extends React.Component<{}, {value: boolean}> {

Style API

+### Subcomponents (pseudo-elements) + +| selector | description | +| ------------------- | ---------------------------------------- | +| ::box | Frame of the checkbox | +| ::icon | Positioning and size for both icons |

No, not as the component is built right now

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/wix/stylable-components/pull/538#discussion_r147063735, or mute the thread https://github.com/notifications/unsubscribe-auth/AIaUyM7J9blZWGChOqeXXZ9TZu9DHb2Hks5swDWEgaJpZM4QF_o6 .