<ContextProvider /> improvements - Githubissues

wix-playground / stylable-components

Fully-tested & strictly-typed component library based on React, using optional Wix styling.

MIT License

35 stars 3 forks source link

<ContextProvider /> improvements #570

Closed AviVahl closed 6 years ago

AviVahl commented 6 years ago

Now forwards upper level context values as well (overwriting with its own).
Refactored tests for readability. no more any. no more let.
Simplified test components.
Rephrased test descriptions to describe the actual behavior being tested.
Tests no longer use ReactDOM.findDOMNode(). We use test-drive's select().
Assertions are now full sentences, in the spirit of chai.
Removed test of Symbol prop, as React doesn't support it yet.

tyv commented 6 years ago

guys, take a look, that is base for call on Tuesday with @AviVahl