search

wix-playground / stylable-components

Fully-tested & strictly-typed component library based on React, using optional Wix styling.
MIT License
35 stars 3 forks source link

Disable TimePicker/DatePicker tests (see desc) #589

Closed AviVahl closed 6 years ago

AviVahl commented 6 years ago

these tests causes browser failures in IE11. It happens in our CI and also locally. Might have to do with the locale settings of the environment being tested on

Committed this to a PR to check if this is indeed the root cause of the issue.

AviVahl commented 6 years ago

@tyv these two components cause IE11 to restart in CI (and crash locally). Probably something that has to do with the date handling.

FYI @wtfil @JoMarton @AlexShemeshWix

JoMarton commented 6 years ago

I feel like we should remove the export of the offending components until we have a definitive answer to why this happens

alisey commented 6 years ago

Could be relevant: https://stackoverflow.com/questions/8648449/jquery-ui-datepicker-causes-internet-explorer-to-crash

tyv commented 6 years ago

good, let's skip it. @wtfil can you look into it closer?

alisey commented 6 years ago

Further details on that jQuery UI Datepicker bug: https://bugs.jqueryui.com/ticket/9593 Seems to be a red herring.