Old school dist - Githubissues

wix-playground / vidi

<video> playback simplified

https://wix.github.io/vidi

Other

31 stars 0 forks source link

Old school dist #11

Closed Elad-Laufer closed 7 years ago

Elad-Laufer commented 8 years ago

Hi,

Seems that dist/vidi.js and dist/vidi.min.js are missing.

Cheers, Elad

AviVahl commented 8 years ago

Keeping a dist in your git repository has downsides: It must/should be kept in-sync for every commit, It allows people to base their projects on your git repo, which is not always what you want.

I rather people would either:

Use npm to install this lib in a npm-based project
Use a .js.min file hosted on a CDN to add it inline inside your HTML/project.

Not sure yet.

abumami commented 8 years ago

I agree that it should be on a CDN (and that it's less desirable to include a dist). In fact, I could use a CDN for the demos that I'm working on for the docs.

AviVahl commented 7 years ago

Implemented a minified UMD build which is available on a CDN: https://github.com/wix/vidi/releases/tag/v0.3.0