Return more information in .getAttributes()

wix / Detox

Gray box end-to-end testing and automation framework for mobile apps

https://wix.github.io/Detox/

MIT License

11.21k stars 1.92k forks source link

Return more information in .getAttributes() #3116

Open noomorph opened 2 years ago

noomorph commented 2 years ago

@asafkorem says in https://github.com/wix/Detox/pull/3009:

Just to point out, it seems like there are more attributes that we can provide with this API (see https://reactnative.dev/docs/accessibility), like accessibilityHint, or accessibilityState.. Sure, out of this PR scope. I'm talking about a change that requires both Android and iOS implementations.

@asafkorem, could you elaborate on this, please? Don't hesitate to change the initial issue description or title if necessary.

asafkorem commented 2 years ago

Taking a look at the iOS implementation, it seems that we can simply provide more UIView's attributes, specifically of accessibility information (apple docs) like the mentioned accessibilityHint, or accessibilityState .. I didn't looked at the Android code but there's no reason that we won't have these attributes easily accessible.

This will allow us to be correlated with RN's accessibility properties (https://reactnative.dev/docs/accessibility).

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

stale[bot] commented 2 years ago

The issue has been closed for inactivity.