Option to overwrite artifacts if they exist

[SMJ93]

Describe your idea

It would be great if we overwrite artifacts such as screenshots or videos by passing through a flag e.g. --overwrite-artifacts.

I've managed to get this working locally by adding the following patch to node_modules/detox/src/artifacts/templates/artifact/FileArtifact.js -> moveTemporaryFile method:

diff --git a/node_modules/detox/src/artifacts/templates/artifact/FileArtifact.js b/node_modules/detox/src/artifacts/templates/artifact/FileArtifact.js
index 7f07040..593662d 100644
--- a/node_modules/detox/src/artifacts/templates/artifact/FileArtifact.js
+++ b/node_modules/detox/src/artifacts/templates/artifact/FileArtifact.js
@@ -87,6 +87,12 @@ class FileArtifact extends Artifact {
       return true;
     }

+    if (await fs.exists(destination)) {
+      logger.debug({ event: 'MOVE_FILE_OVERWRITE' }, `moving "${source}" to ${destination}`);
+      await fs.move(source, destination, { overwrite: true });
+      return true;
+    }
+
     logger.warn({ event: 'MOVE_FILE_EXISTS' }, `cannot overwrite: "${source}" => "${destination}"`);
     await fs.remove(source);
     return false;

It checks if the file exists at the destination and then passes through the flag option overwrite: true to fs.move

[noomorph]

Could you explain your scenario a bit more? 🙏

[SMJ93]

Hey @noomorph, sure.

I use Detox device.takeScreenshot to generate screenshots for my iOS and Android app:

• 5 devices (iphone8Plus, iphone11ProMax, iPadPro12Inch, pixel4, pixelTablet)
• 15 languages
• 6 screenshots per device

I am currently uploading all 450 screenshots to the App Store and Google Play Store manually.

The plan is to automate the entire screenshot generation and upload process using Detox and fastlane deliver.

So I don't need to generate fresh screenshots each time I want to upload to the stores I commit the screenshots.

There are some scenarios where I want to overwrite these screenshots, for example a new design / feature. In this case I need the { overwrite: true } otherwise it fails at the following line:

     logger.warn({ event: 'MOVE_FILE_EXISTS' }, `cannot overwrite: "${source}" => "${destination}"`);

[noomorph]

Ah, hehe, interesting... I'll think. :)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

[stale[bot]]

The issue has been closed for inactivity.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

[stale[bot]]

The issue has been closed for inactivity.