wix / greyhound

Greyhound - Rich Kafka client library
MIT License
516 stars 37 forks source link

add sidecar batch consumer #480

Closed gavinrifkind closed 2 years ago

natansil commented 2 years ago

@gavinrifkind did you manage to get the two servers successfully running with batch consumer?

gavinrifkind commented 2 years ago

Yes

On Sunday, September 18, 2022, Natan Silnitsky @.***> wrote:

@gavinrifkind https://github.com/gavinrifkind did you manage to get the two servers successfully running with batch consumer?

— Reply to this email directly, view it on GitHub https://github.com/wix/greyhound/pull/480#issuecomment-1250342469, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3RFDVC2LHBWX2BVC2BE6TV647DFANCNFSM6AAAAAAQNLXYQA . You are receiving this because you were mentioned.Message ID: @.***>

natansil commented 2 years ago

great! Can you please just remove the debug messages and merge? Thank you so much for a job well done!

On Sun, Sep 18, 2022 at 9:14 PM Gavin Rifkind @.***> wrote:

Yes

On Sunday, September 18, 2022, Natan Silnitsky @.***> wrote:

@gavinrifkind https://github.com/gavinrifkind did you manage to get the two servers successfully running with batch consumer?

— Reply to this email directly, view it on GitHub https://github.com/wix/greyhound/pull/480#issuecomment-1250342469, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB3RFDVC2LHBWX2BVC2BE6TV647DFANCNFSM6AAAAAAQNLXYQA

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/wix/greyhound/pull/480#issuecomment-1250360090, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZVURJASSWCJ3RXC3EVM73V65LZXANCNFSM6AAAAAAQNLXYQA . You are receiving this because your review was requested.Message ID: @.***>

-- Best,

Natan Silnitsky Hanamal street, Tel Aviv, Israel

gavinrifkind commented 2 years ago

@natansil I removed all the debug messages from SidecarService. Please review to make sure that I didn't remove something that is still required Also I left the debug messages in the SidecarUserService, because for now it is the only way to see that it is actually doing something