search

wix / greyhound

Greyhound - Rich Kafka client library
MIT License
516 stars 37 forks source link

Add persistent tentant registry #555

Open TomasMonkevic opened 1 year ago

TomasMonkevic commented 1 year ago

What is done:

  1. Wired up Redis
  2. Implemented logic of registry repo implementation selection based on environment config

What is still in to do:

  1. Move shutdown field from TenantConsumerInfo class
  2. Implement in memory registry repo (moving the current implementation)
  3. Implement Redis registry repo
  4. Add test with Redis registry repo implementation usage
TomasMonkevic commented 1 year ago

If no env var is set in the image, will redis run or in-memory run?

In-memory will run

Currently with docker-compose, does sidecar connect to redis?

It doesn't because the environment variable isn't provided.

natansil commented 1 year ago

Cool. sounds good!