search

wix / react-native-calendars

React Native Calendar Components 🗓️ 📆
MIT License
9.6k stars 2.97k forks source link

FlashList #2153

Open nisseenn opened 1 year ago

nisseenn commented 1 year ago

Description

is there any plans for this package to swap FlatList with FlashList to improve performance in future versions?:) https://shopify.github.io/flash-list/

KrisLau commented 1 year ago

@Inbal-Tish @tautvilas @ethanshar ?

pencilcheck commented 1 year ago

Please, right now calendar list is having memory leak everytime I load events in it, please change to flashlist

nisseenn commented 1 year ago

Dont know if this might help others, but we decided to try to swap the FlatList: https://medium.com/p/4885b420d2b2

pencilcheck commented 1 year ago

Dont know if this might help others, but we decided to try to swap the FlatList: https://medium.com/p/4885b420d2b2

Thanks! Scrolling is now very fast!! now i just need to figure out how to memoize the calendar component so it loads faster when scrolled to.

KrisLau commented 1 year ago

@nisseenn Doesn't work for AgendaList since it's a SectionList and also I have no clue where the AgendaList is extending the SectionList

rahul2992 commented 1 year ago

We tried to use FlashList with calendar components as individual items. The performance on iOS is pretty good, but lots of whitespaces on android. I think it might be because react-native-calendars has key props in days and weeks.

KrisLau commented 1 year ago

@rahul2992 AgendaList is still using SectionList and it's having a ton of performance issues when there is a lot of items passed to it:

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

NiharR27 commented 1 year ago

bump, i had to write my own Agenda (with Flashlist) and Expandable calendar.

aydahealth commented 11 months ago

@nisseenn Can you share your implementation of swapping the flat list with flash list?

imckain commented 10 months ago

Would love this feature. Had to write my own AgendaList component.

MarceloPrado commented 9 months ago

You might want to try https://github.com/marceloPrado/flash-calendar - a new package I built that natively supports Flash List 🙂