wix / react-native-calendars

React Native Calendar Components 🗓️ 📆
MIT License
9.58k stars 2.96k forks source link

Expandable calendar knob can pull it all the way down #2185

Open WilsonZyj opened 1 year ago

WilsonZyj commented 1 year ago

Please make our job easier by filling this template out to completion. If you're requesting a feature instead of reporting a bug, please feel free to skip the Environment and Reproducible Demo sections.

Description

When I use Expandable calendar, it's knob can be pulled down all the way

Expected Behavior

Is it possible to set a maximum height for the Expandable calendar to prevent it from going all the way down or some other way to solve the problem?

Observed Behavior

Environment

"react": "17.0.1", "react-native": "0.64.4", "react-native-calendars": "^1.1293.0",

Also specify:

  1. Device/emulator/simulator & OS version:

Reproducible Demo

It's the same for Android and ios

Screenshots

da3b35b09f069ff5423fed1d801584bc

dipak-tomar commented 1 year ago

@WilsonZyj same problem i am facing

WilsonZyj commented 1 year ago

I tried to modify the source code to make it look like it can't be pulled down all the way

dipak-tomar commented 1 year ago

@WilsonZyj can u share it with me

WilsonZyj commented 1 year ago

react-native-calendars/src/expandableCalendar/style.js Go to this file and delete the position property from the knobContainer stylesheet。 But this can only be solved in terms of UI style, not fundamentally。 I'm not sure if this is the only place that needs to be modified. If it doesn't take effect, please let me know。

dipak-tomar commented 1 year ago

thanks buddy will check it, i think the main problem is with pan responder there should be max downward limit

dipak-tomar commented 1 year ago

@WilsonZyj how do you persist change in source code , which package you used ?

WilsonZyj commented 1 year ago

Yes,I also changed other codes to add the maxheight limit。 I only modified my local source code。 I'm using version 1.1293.0。

dipak-tomar commented 1 year ago

@WilsonZyj can u send that also

WilsonZyj commented 1 year ago

/react-native-calendars/src/expandableCalendar/index.js. Go to this file and add the maxHeight attribute to the style of the imported Calendar. By the way, when using Expandable, you can't pull up directly. You have to slide down first to pull up. Have you solved this problem.

dipak-tomar commented 1 year ago

@Inbal-Tish can u pls check this issue this happens with me everytime

WilsonZyj commented 1 year ago

@dipak-tomar You mean the problem of pull up?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.