wix / react-native-calendars

React Native Calendar Components 🗓️ 📆
MIT License
9.31k stars 2.89k forks source link

Update not reflect in UI #2464

Open chingthampiyarilal opened 1 month ago

chingthampiyarilal commented 1 month ago

Description

In Agenda Calender,I creating different event on same date if i tried to update the each event everything is reflected on the data but not the UI.

Expected Behavior

I change to delete inside the package module reservation.js "shouldComponentUpdate(nextProps) {....." ===> When i change this part it works fine

Observed Behavior

Updating event not reflected in the UI but all are reflected in data/ logs..

I dont have any error but

I have a warning : VirtualizedList: You have a large list that is slow to update - make sure your renderItem function renders components that follow React performance best practices like PureComponent, shouldComponentUpdate, etc. {"contentLength": 2948, "dt": 843, "prevDt": 883} ! a b

Environment

Please run these commands in the project folder and fill in their results:

Also specify:

  1. Device/emulator/simulator & OS version: Copy_of_Pixel_6_Pro_API_33

Reproducible Demo

Screenshots or gifs of the issue and the suggested fix will help us move faster with the review process.

srinu6 commented 2 weeks ago

I am also facing the same issue, were you able to fix this issue? @chingthampiyarilal

chingthampiyarilal commented 1 week ago

@srinu6, It works when i delete "shouldComponentUpdate(nextProps) {....." function, inside the node_modules\react-native-calendars\src\agenda\reservation-list\reservation.js

hughyyyy commented 3 days ago

Yes, I can confirm, shouldComponentUpdate is not working properly.