search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

[V2] Large title in modal doesn't show until scroll #3680

Closed jacobrosenskold closed 5 years ago

jacobrosenskold commented 6 years ago

Issue Description

Large title in modal doesn't show until scroll.

Steps to Reproduce / Code Snippets / Screenshots

  static get options() {
    return {
      topBar: {
        title: { text: 'More' },
        largeTitle: { visible: true },
        rightButtons: [
          {
            title: 'Done',
            id: 'done'
          }
        ]
      }
    };
  }

ezgif com-video-to-gif

Environment

jacobrosenskold commented 6 years ago

Also strange animation when you go back from a screen without large title to a screen with large title. ezgif com-video-to-gif 1

nicolaslopezj commented 6 years ago

Related https://github.com/wix/react-native-navigation/pull/3610

srogers202 commented 6 years ago

I've tested the change in #3610, but I don't think it resolves this issue fully. When navigating to a bottom tab, the title is small until scrolling down. After returning to that tab, the large title persists.

Any ideas on why the large title is not showing initially? I've been working on a solution, but I haven't found the root cause.

zcmgyu commented 6 years ago

Same issue.

ericlewis commented 6 years ago

Also having this issue, will try to investigate. Seems related to scrollViews

mikeletscher commented 6 years ago

I am currently experiencing this issue as well. Will see if I can figure out a short term solution.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] commented 5 years ago

The issue has been closed for inactivity.

chrise86 commented 5 years ago

I'm still having this issue on single component screens, not even inside modals.

ghost commented 5 years ago

For me, #3610 worked.

chrise86 commented 5 years ago

Doesn’t do anything for me

matpaul commented 5 years ago

Found fix,

1) drawBehind should be true,

2) in screen 

const {height} = Dimensions.get('window')
...
render() {
  return (<View style={{height}}><ScrollView>....</ScrollView></View>);
}
chrise86 commented 5 years ago

@matpaul that also doesn't work for me. It resolves the scrolling up issue, however when the view loads the topBar is extra large and pops back up (to small) when the FlatList content loads (from a network request).

UPDATE: it looks like the issue is to do with the refresh controls. When pulling down to refresh the controls appear below the large topBar when they should be above it. I think this is causing some layout issues. Seems to be directly related to https://github.com/wix/react-native-navigation/issues/5152.