search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

[V2] [iOS] Peek and Pop on iOS using Navigation.TouchablePreview crashes the app #3693

Closed yuannypants closed 2 years ago

yuannypants commented 6 years ago

Issue Description

Implementing the recently refactored peek and pop function for iOS (#3620) crashes the app.

Steps to Reproduce / Code Snippets / Screenshots

To reproduce the crash, you can implement either the demo from #3620 or the example from https://wix.github.io/react-native-navigation/v2/#/docs/animations.

img_6b88919734e4-1

You may refer to the error message/callstack below. I don't know how to format the error message properly but I do hope it helps!

Exception '-[NSDictionaryM floatValue]: unrecognized selector sent to instance 0x1c0032060' was thrown while invoking push on target RNNBridgeModule with params ( push12, Component8, { children = ( ); data = { name = "flicc.ActivityScreen"; options = { preview = { reactTag = { reactTag = 1409; }; }; }; }; id = Component11; type = Component; }, 2396, 2397 ) callstack: ( 0 CoreFoundation 0x000000018519ada4 + 252 1 libobjc.A.dylib 0x00000001843545ec objc_exception_throw + 56 2 CoreFoundation 0x00000001851a8098 + 0 3 CoreFoundation 0x00000001851a05c8 + 1380 4 CoreFoundation 0x000000018508641c _CF_forwarding_prep_0 + 92 5 Flicc 0x00000001014ea97c -[RNNCommandsHandler push:layout:completion:rejection:] + 420 6 Flicc 0x00000001014bbe54 -[RNNBridgeModule push:componentId:layout:resolver:rejecter:] + 360 7 CoreFoundation 0x00000001851a2580 + 144 8 CoreFoundation 0x0000000185081748 + 284 9 CoreFoundation 0x000000018508656c + 60 10 Flicc 0x0000000100eb3200 -[RCTModuleMethod invokeWithBridge:module:arguments:] + 2064 11 Flicc 0x0000000100f5de58 _ZN8facebook5reactL11invokeInnerEP9RCTBridgeP13RCTModuleDatajRKN5folly7dynamicE + 664 12 Flicc 0x0000000100f5d9e8 _ZZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEiENK3$0clEv + 132 13 Flicc 0x0000000100f5d958 ZN8facebook5react15RCTNativeModule6invokeEjON5folly7dynamicEi_block_invoke + 28 14 libdispatch.dylib 0x0000000184a8caa0 + 24 15 libdispatch.dylib 0x0000000184a8ca60 + 16 16 libdispatch.dylib 0x0000000184acdd80 + 964 17 CoreFoundation 0x0000000185143070 + 12 18 CoreFoundation 0x0000000185140bc8 + 2272 19 CoreFoundation 0x0000000185060da8 CFRunLoopRunSpecific + 552 20 GraphicsServices 0x0000000187046020 GSEventRunModal + 100 21 UIKit 0x000000018f080758 UIApplicationMain + 236 22 Flicc 0x0000000100dc4a44 main + 124 23 libdyld.dylib 0x0000000184af1fc0 + 4 )

RCTFatal facebook::react::invokeInner(RCTBridge, RCTModuleData, unsigned int, folly::dynamic const&) facebook::react::RCTNativeModule::invoke(unsigned int, folly::dynamic&&, int)::$_0::operator()() const invocation function for block in facebook::react::RCTNativeModule::invoke(unsigned int, folly::dynamic&&, int)

CFRunLoopRunSpecific GSEventRunModal UIApplicationMain main --- ### Environment * React Native Navigation version: 2.0.2454 * React Native version: 0.56.0 * Platform(s) (iOS, Android, or both?): iOS * Device info (Simulator/Device? OS version? Debug/Release?): iPhone 8+ / iOS 11.4.1 / Debug
stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] commented 6 years ago

The issue has been closed for inactivity.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] commented 2 years ago

The issue has been closed for inactivity.