search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

[V2] ScrollView/FlatList after changing route/pushing/showing modal while there is a momentum scroll #4325

Closed jimmyloi closed 3 years ago

jimmyloi commented 5 years ago

Issue Description

This is the similar bug that happened in V1 and it got fixed but now it comes back in V2. #1446

Steps to Reproduce / Code Snippets / Screenshots

  1. Scroll few items.
  2. While there is a momentum scrolling => switch to the 2nd tabbar screen
  3. Return to the 1st screen and try to click a FlatList cell => cells are not responsive.

Environment

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] commented 5 years ago

The issue has been closed for inactivity.

exentrich commented 5 years ago

Issue is still exist on latest RNN

flikQ commented 5 years ago

@guyca how come there are so many bugs and issues being closes and moved to 'done' when they are not fixed?

I am curious on the reasoning of the team/contributors that are leaving bugs unfixed but marking them as fixed.

Specifying them as closed won't make the issues go away.

jimmyloi commented 5 years ago

It is because they are refactoring the architecture so some bugs reappear.

wellcode commented 5 years ago

Have the same problem, is there a plan to fix it?

Crisis2010 commented 5 years ago

Still exist, need fix

manuhook commented 5 years ago

Any update on this problem ? Thanks 🙏

jimmyloi commented 5 years ago

Sorry. I was able to fix this issue by stopping the momentum scroll before pushing screen or showing modal.

I'm busy fixing my other issues so I haven't submitted a pull request yet. I will do it once I have time.

You can see my forked version for the fix.

https://github.com/minhloi/react-native-navigation/commit/108e9b3b2d489916c92d3e9a6b0d461759915ea1#diff-54fb69abd59c84c3119510a4ae58d80a

exentrich commented 5 years ago

@minhloi thank you very much! Would be great if you find a time to make pull request!

manuhook commented 4 years ago

@minhloi thanks a lot ! I will be also very grateful if you can make a pull request as the problem is still present on RNN V3. Thanks again !

manuhook commented 4 years ago

Hi @yogevbd

Please can you add those changes on master ? This issue is still present on V4 and and our iOS users regularly complain about it since a long time. https://github.com/minhloi/react-native-navigation/commit/108e9b3b2d489916c92d3e9a6b0d461759915ea1#diff-54fb69abd59c84c3119510a4ae58d80a

Thanks you !

nathantqn commented 4 years ago

Hi, I'm facing the same issue, it's quite annoying, is there any plan to add the changes from @minhloi to the master :( . Thank you

nathantqn commented 4 years ago

Hi @guyca, I'm still facing this issue in the "react-native-navigation": "^6.9.0" on iOS. It's quite annoying, is there any plan to add the changes from @minhloi to the master :( . Thank you

manuhook commented 4 years ago

Hi @yogevbd, unfortunatly I'm still having the issue with "react-native-navigation 6.12.0". I'm not seeing any chance with your patch. I'm simply doing what's it's described on the issue : On the first Tab Scroll few items. While there is a momentum scrolling => switch to the 2nd tabbar screen Return to the 1st screen and try to click a FlatList cell => cells are not responsive.

manuhook commented 4 years ago

It's working when you add this 2 lines on RNNBottomTabsController.m :

line 3 :

import "UIView+Utils.h"

line 161 : [self.view stopMomentumScrollViews];