wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

Infinite loop When TextInput #5146

Closed ljh740 closed 3 years ago

ljh740 commented 5 years ago

Using IQKeyboardManager causes an infinite loop

when click TextInput RNNNavigationController causes IQKeyboardManager to cause an infinite loop

code:


In  IQKeyboardManager

@implementation UIView (IQ_UIView_Hierarchy)
...
-(UIViewController *)parentContainerViewController
{
...
        while (navController.navigationController) {
            navController = navController.navigationController;
        }
...
}
...
@end

In react-native-navigation
@implementation RNNNavigationController
...

- (UINavigationController *)navigationController {
    return self;
}

...
@end

Environment

danilobuerger commented 3 years ago

It doesn't make sense to keep this open anymore.

1) IQKeyboardManager has been converted to swift, so things changed 2) We no longer have RNNNavigationController or the shown method 3) Nobody was interested to fix this issue for 1,5 years.

If this issue still exists with the current versions of IQKeyboardManager and RNN, feel free to reopen.

mateioprea commented 3 years ago

I'm using IQKeyboardManager with RNN and it doesn't cause any infinite loops