wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

[V3][iOS] App with SplitView crash on iPad Slide Over #5632

Closed exentrich closed 4 years ago

exentrich commented 5 years ago

Issue Description

SplitView works fine when app is in fullscreen, but when it resized to less than 70% of width, it crash. Check Playground app. This happen only when master and detail have a stack child. But not crash if any of them have bottomTabs as a child. As you can see in example code below.

bottomTabs solution is appropriate workaround for me, but I don't know how to make detail navigation controller appear again after user tapped back button. Does I miss something?

Steps to Reproduce / Code Snippets / Screenshots

Crashing:

Navigation.setRoot({
    root: {
        splitView: {
            master: {
                stack: {
                    children: [
                        {
                            component: {
                                name: 'navigation.playground.WelcomeScreen'
                            },
                        },
                    ]
                },
            },
            detail: {
                stack: {
                    children: [
                        {
                            component: {
                                name: 'navigation.playground.WelcomeScreen'
                            },
                        },
                    ]
                }
            }
        }
    }
})

Works fine:

Navigation.setRoot({
    root: {
        splitView: {
            master: {
                stack: {
                    children: [
                        {
                            component: {
                                name: 'navigation.playground.WelcomeScreen'
                            },
                        },
                    ]
                },
            },
            detail: {
                bottomTabs: {
                    children: [
                        {
                            stack: {
                                children: [
                                    {
                                        component: {
                                            name: 'navigation.playground.WelcomeScreen'
                                        },
                                    }
                                ]
                            }
                        },
                    ]
                }
            }
        }
    }
})

Environment

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

stale[bot] commented 4 years ago

The issue has been closed for inactivity.