wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

Using the default Android 9 animation for stack/modal push #6060

Open drewhamlett opened 4 years ago

drewhamlett commented 4 years ago

Issue Description

I think in Android 9 they introduced a new animation that I see all apps using on my phone. The slide up animation doesn't seem to be the default anymore. I don't think it's necessary to try to recreate this with the animation properties since it's a default thing. Much like the default iOS transition.

Steps to Reproduce / Code Snippets / Screenshots

ezgif-7-ffdf3866b7e1

ezgif-7-87bbe88f0118

ezgif-7-a1019b128087

If you create a new react-navigation stack with the native stack it uses the correct one by default. It's a little off because the status bar doesn't behave correctly.

animation

Thanks for any help!


Environment

guyca commented 4 years ago

Hey @drewhamlett 👋 These are Activity and Fragment animations. The reason your app doesn't leverage these animations is simply because RNN uses neither Activities or Fragments.

To use these animations, we'll first need to implement enter and exit animations for both appearing and disappearing screens. Right now, when pushing a screen you can only animate the entering (pushed screen) or the exiting (popped) screen.

I plan to get to this by next quarter 🙏

remstos commented 4 years ago

Hi, This would be really appreciated, thanks for putting it in the backlog, any update on the timeline? 🙏

guyca commented 4 years ago

Hey @remstos This is still planned and prioritised unfortunately this keeps getting delayed by more important tasks.

todorone commented 3 years ago

Hi @guyca

Is there any update regarding this? This slide-from-bottom animation looks really outdated nowadays...😼

badaz commented 3 years ago

I'd be happy to have an update on this too, or someone kindly sharing the animation settings required to obtain this effect, thanks ;)

samjayhk commented 3 years ago

@guyca Is there have any update? Thanks :)

badaz commented 2 years ago

@guyca has there been any progress on this matter? Tx ;)

jeffinhk commented 1 year ago

still going on?

galaxykhh commented 10 months ago

still same