wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

iOS 15 UISheetPresentationController Detents #7320

Open zachgibson opened 2 years ago

zachgibson commented 2 years ago

🚀 Feature

It would be great to support iOS 15 UISheetPresentationController detents so page sheet modals can have multiple “snap points”.

Motivation

This would allow for greater customization and enhanced user experience when using page sheet modal styles in iOS 15 and greater.

Pitch

One of the main benefits I see of this feature would be a native stack inside a “bottom sheet”. This is currently impossible AFAIK to inject a native RNN stack into a RN based bottom sheet. This would also be a great alternative to React Native or JS based bottom sheets where performance and UX sometimes suffer.

Are you willing to resolve this issue by submitting a Pull Request?

svbutko commented 2 years ago

I can try to implement it, I have an interest in this feature too, I'll try to do something about it this week.

zachgibson commented 2 years ago

I'm here too if I can help out in any way.

zachgibson commented 2 years ago

@svbutko any updates on this?

svbutko commented 2 years ago

@zachgibson sorry I don't have enough time at this moment, the PR which is there in drafts has everything implemented, there are just two issues which have nothing to do with the feature itself but with the way how data is passed from RN to native, and if it will be fixed, then everything should work

oferRounds commented 1 year ago

hi any chance this can be continued?

oferRounds commented 7 months ago

hey @yogevbd, any plans to finish the support for this iOS feature?