feat: support base64 images on bottom tabs

wix / react-native-navigation

A complete native navigation solution for React Native

https://wix.github.io/react-native-navigation/

MIT License

13.04k stars 2.67k forks source link

feat: support base64 images on bottom tabs #7691

Closed asherLZR closed 1 year ago

asherLZR commented 1 year ago

Currently images for bottom tabs must be from a local resource. One way to support dynamic images such as for a profile image in the bottom tabs is to allow base64 images. This seems to work already for iOS but we can add a little extra logic to support this on Android.

The code is not perfect, but happy to refactor if this is something worth considering.

Test plan Open the app in the playground app (example provided)

xgenem commented 1 year ago

Do you think you can modify to allow component as well?

stale[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

The issue has been closed for inactivity.