search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.04k stars 2.67k forks source link

Merging options to set bottom tabs text clears badge #7692

Closed asherLZR closed 1 year ago

asherLZR commented 1 year ago

What happened?

The following code clears the badge on iOS (not Android)

Navigation.mergeOptions(this, {
  bottomTab: { badge: 'NEW' },
});

// then

Navigation.mergeOptions(this, {
      bottomTab: { text: 'Tab 1 New Text' },
});

https://user-images.githubusercontent.com/32557572/223184636-202a77ca-0288-4639-8434-e65144b337e7.mov

What was the expected behaviour?

Setting text does not clear the badge

Was it tested on latest react-native-navigation?

Help us reproduce this issue!

On the following branch, click Set Badge then Set tab text

https://github.com/wix/react-native-navigation/compare/master...asherLZR:react-native-navigation:replication-ios-set-text-clears-badge

In what environment did this happen?

React Native Navigation version: master React Native version: 0.6.7 Has Fabric (React Native's new rendering system) enabled: no Node version: 18.14.2 Device model: iPhone SE iOS version: 15.4

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

stale[bot] commented 1 year ago

The issue has been closed for inactivity.