fix: measure overlay touch based on child dimensions

wix / react-native-navigation

A complete native navigation solution for React Native

https://wix.github.io/react-native-navigation/

MIT License

13.04k stars 2.67k forks source link

fix: measure overlay touch based on child dimensions #7704

Closed asherLZR closed 1 year ago

asherLZR commented 1 year ago

Attempts to resolve https://github.com/wix/react-native-navigation/issues/7674 in a backward compatible and "cast-safe" way based on the fix from @likesebiii. In RN71 there are additional view groups which prevent interceptTouchOutside from getting the correct hitbox.

The build config branch doesn't feel ideal so any suggestions on how to improve are welcome.

RN 0.71

RN 0.70

Test Plan

Use this as a patch in both 0.70 and 0.71 apps, checking interceptTouchOutside true and false on overlay.

MatthewPattell commented 1 year ago

@yogevbd Hello. Can I ask you to merge this fix? The problem interferes with development on android. This is an important change.

Thank you.

helenachallitanumu commented 1 year ago

Try to downgrade RNN Version to 7.35.0.

On Tue, Aug 15, 2023 at 7:45 PM manikandanb24 @.***> wrote:

Its still hapenning with newArchEnabled. If I disable newArchEnabled it works fine.

Not able to interact with both Modal and Overlay

RNN Version - 7.37.0 RN Version - 0.72.4

— Reply to this email directly, view it on GitHub https://github.com/wix/react-native-navigation/pull/7704#issuecomment-1679278258, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYZPBGKO5JVGSXZPY735MG3XVORTFANCNFSM6AAAAAAXOI2IMY . You are receiving this because you commented.Message ID: @.***>