search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.02k stars 2.67k forks source link

Android 14 compatibility #7751

Closed androideveloper closed 9 months ago

androideveloper commented 1 year ago

What happened?

We are exploring Android 14 and possibility to target it as soon as possible. In Android 14, Runtime-registered broadcasts receivers must specify export behavior.

There's one place in rn-navigation library, where a broadcast is registered without specifying the export behaviour. You can find it here. The way to fix this is bumping androidx.core dependency to be able to use the latest APIs for ContextCompat class.

On the other hand, we've noticed, that this class JsDevReloadHandler is initialized on app start, even for release builds. I've not found any checks for debug/release in the code. Isn't this supposed to run only on debug version of the app?

What was the expected behaviour?

Was it tested on latest react-native-navigation?

Help us reproduce this issue!

No response

In what environment did this happen?

React Native Navigation version: 7.32.1 React Native version: 0.71.7 Has Fabric (React Native's new rendering system) enabled: no Node version: 16.14.2 Device model: Pixel 6 Pro, android 14 beta Android version: 14

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

androideveloper commented 1 year ago

It's still relevant

stale[bot] commented 11 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe the issue is still relevant, please test on the latest version and report back. Thank you for your contributions.

ghost commented 9 months ago

I am facing same issue how I can fix this ?

yogevbd commented 9 months ago

https://github.com/wix/react-native-navigation/pull/7801 merged, closing