search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.02k stars 2.67k forks source link

change #7156 modals no longer work on iOS #7752

Closed RobertGary1 closed 1 year ago

RobertGary1 commented 1 year ago

What happened?

Updated from 7.17.0 to 7.17.1 modal dialogs stop working on iOS

import { , Modal, Text,, View } from 'react-native';

  <Modal
      presentationStyle={'pageSheet'}
      animationType="slide"
        visible={true}
      <View style={{backgroundColor: 'white'}}>
hello

</View

What was the expected behaviour?

Modal should appear as they do in 7.17.0

Was it tested on latest react-native-navigation?

Help us reproduce this issue!

import { , Modal, Text,, View } from 'react-native';

  <Modal
      presentationStyle={'pageSheet'}
      animationType="slide"
        visible={true}
      <View style={{backgroundColor: 'white'}}>
hello

</View

In what environment did this happen?

React Native Navigation version: react-native-navigation": "7.17.1",

React Native version: "react-native": "0.66.1",

Has Fabric (React Native's new rendering system) enabled:no Node version: 16.13.2 Device model: iphone 14 iOS version: 16.2

RobertGary1 commented 1 year ago

Looks like this chnage is when it stopped working https://github.com/wix/react-native-navigation/pull/7156

scottgrunerud commented 1 year ago

I am also having this issue

yogevbd commented 1 year ago

hey, did you test it on the latest RNN version?