wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.01k stars 2.68k forks source link

[Android] Height changes when mergeOptions is called #7800

Open ldstein opened 9 months ago

ldstein commented 9 months ago

What happened?

If the statusBar visibility is false:

Navigation.setDefaultOptions({
        statusBar: {
            visible: false
        },
    })

a subsequent call to Navigation.mergeOptions() will increase the application height:

Navigation.mergeOptions(props.componentId, { topBar: { title: { text: Date.now() + "" } } });

image

What was the expected behaviour?

The application height should not be cutoff on the bottom.

Was it tested on latest react-native-navigation?

Help us reproduce this issue!

Repo: https://github.com/ldstein/ReactNativeNavigationBugFix

In what environment did this happen?

React Native Navigation version: 7.37.1 React Native version: 0.72.6 Has Fabric (React Native's new rendering system) enabled: No Node version: 18.10.0 Device model: Pixel 3 (physical device), Pixel 7 Pro (simulator) Android version: Android 11 (Pixel 3), Android 13 (Pixel 7 Pro)