fix(iOS): implement `scaleX` and `scaleY` transition animations.

wix / react-native-navigation

A complete native navigation solution for React Native

https://wix.github.io/react-native-navigation/

MIT License

13.01k stars 2.68k forks source link

fix(iOS): implement `scaleX` and `scaleY` transition animations. #7807

Closed oblador closed 3 months ago

oblador commented 8 months ago

I was tearing my hair over why I couldn't get scale transitions to work on iOS while they were working fine on Android, and it turns out it was never implemented 😅

This PR adds this implementation.

Fixes #7066

oblador commented 8 months ago

Not sure about the failing tests, seems unrelated write error: No space left on device

stale[bot] commented 4 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

oblador commented 4 months ago

Bad bot

oblador commented 3 months ago

@asafkorem Any chance this could get some eyes on it?

asafkorem commented 3 months ago

Yes @oblador, I'll review it later this week

oblador commented 3 months ago

Awesome, thanks for the review! Would you mind delegating another PR that I’ve had open for quite some time? https://github.com/wix/react-native-navigation/pull/7809

asafkorem commented 3 months ago

Sure @oblador