Fix `kotlin` build issues with react native 73.x

wix / react-native-navigation

A complete native navigation solution for React Native

https://wix.github.io/react-native-navigation/

MIT License

13.04k stars 2.67k forks source link

Fix `kotlin` build issues with react native 73.x #7831

Closed siddarthkay closed 4 months ago

siddarthkay commented 8 months ago

In this PR we do the following :

We make sure react-native-navigation uses java 17 which is needed by react-native 0.73.1
We fix a type mismatch error when executing this gradle task :react-native-navigation:compileReactNative71DebugKotlin

fixes #7819

relevant patch in status-mobile repo : https://github.com/status-im/status-mobile/pull/18496/files#diff-b3d31b1df4cceb663a7dba96bcc3ea45686afe2208d7945b6e7e269067d753fbR100-R106

Spxc commented 8 months ago

Any status on release for this?

siddarthkay commented 8 months ago

Tests are failing, I'll try to fix the tests this weekend

Spxc commented 8 months ago

Tests are failing, I'll try to fix the tests this weekend

Thanks, i did a PR as well (with test failing, what a surprise haha), with a bit more changes to the ButtonPresenter

https://github.com/wix/react-native-navigation/pull/7842

siddarthkay commented 6 months ago

Hi @asafkorem @d4vidi @yogevbd How important is postCommandsOnMainThread_doesNotCrashIfActivityIsNull test? can this be skipped? This is the only test that fails on this PR when i run npm run test-unit-android -- --release

If not could you please provide some assistance here so that we can make progress on this PR :)

Thank you

siddarthkay commented 4 months ago

closing in favour of https://github.com/wix/react-native-navigation/pull/7864