search

wix / react-native-navigation

A complete native navigation solution for React Native
https://wix.github.io/react-native-navigation/
MIT License
13.01k stars 2.68k forks source link

Android - Left buttons are not in order #7847

Closed NikitaShavit closed 4 months ago

NikitaShavit commented 4 months ago

What happened?

Android - Left buttons are in opposite order then IOS, or the order we send them in. In our code we send navigation options the next way:

export const getTopBarLeftButtons = () => {
  const backButton = {
    id: NAV_BUTTON_IDS.BACK,
    icon: Assets.icons.navigation.back,
  };

  const infoButton = {
    id: NAV_BUTTON_IDS.INFO,
    icon: Assets.icons.general.questionmarkOutline,
  };

  return shouldShowViewCTAInsideCustomizer() ? [backButton, infoButton] : [infoButton];
};

But the result is different on IOS and Android, adding screenshots as an example:

What was the expected behaviour?

Buttons must in same order in IOS and android.

Was it tested on latest react-native-navigation?

Help us reproduce this issue!

https://github.com/wix-private/wix-one-app-member-view/blob/a382ca73e2d5deca75af70ea41c8d054212bd894/packages/wix-one-app-member-view/src/screens/Editor/index.tsx#L76-L77

In what environment did this happen?

React Native Navigation version: Latest React Native version: 0.71 Has Fabric (React Native's new rendering system) enabled: IDK Node version: 16.20 Device model: All Android version: 10